Skip to content

Feature: one2one_freq() to visualize frequency of 1:1 meetings with managers#95

Merged
moralec merged 9 commits into
mainfrom
feature/manager_report
Mar 11, 2021
Merged

Feature: one2one_freq() to visualize frequency of 1:1 meetings with managers#95
moralec merged 9 commits into
mainfrom
feature/manager_report

Conversation

@moralec

@moralec moralec commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Summary

This branch implements the one2one_freq() visualization as specified in #90.

one2one_freq() calculates and visualizes the typical frequency of 1:1 meetings with managers.

Changes

The changes made in this PR are:

  1. Adds one2one_freq().

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.

Example

one2one_freq(sq_data,
             hrvar = "Organization",
             return = "plot",
             mode = "sum")

image

one2one_freq(sq_data,
             hrvar = "Organization",
             return = "plot",
             mode = "dist")

image

Notes

This fixes #90.

@moralec moralec requested a review from martinctc March 4, 2021 12:53
@martinctc martinctc added the enhancement New feature or request label Mar 4, 2021
@martinctc martinctc changed the title Feature/one2one_freq Feature: one2one_freq() to visualize frequency of 1:1 meetings with managers Mar 9, 2021
Also replaced variable name with "Cadence_of_1_on_1_meetings_with_manager" to ensure plot titles are showing up properly.

@martinctc martinctc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great - thanks @moralec! Made a few minor tweaks but happy for this to be merged in.

@moralec moralec merged commit 3087697 into main Mar 11, 2021
@moralec moralec deleted the feature/manager_report branch March 11, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: one2one_freq()

2 participants