Documentation: CRAN Compliance#67
Merged
Merged
Conversation
This takes this one step further for the issue flagged in #68 and makes it a default behaviour to not show variable name checks at the beginning of the four main baseline reports.
Satisfy CRAN requirements. Use `donttest{}` where possible.
Previously withr approach was not working
At places, also some cleaning up relating to #31.
Put family as param by mistake
Add `identify_churn()`
- Adjust family - Created two templates: ch.R and spq-params.R - General code formatting
Aligned all function family with this commit.
One stray `dontrun{}`
This was
linked to
issues
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch implements a number of documentation changes in order to be compliant with CRAN review guidelines. This is a continuation of #54 to implement more CRAN compliance measures.
Changes
The changes made in this PR are as follows.
Relevant to CRAN checks
returnoptions consistently for all functions (Documentation:returnoptions are not consistently shown #31)par()andoptions()withon.exit(par(old_par))to avoid changing user options (Fix: do not change user options or par fornetwork_p2p()#60)Miscellaneous fixes and improvements
meetingtype_summary()andidentify_churn().active_thresholdargument toworkpatterns_classify(), which was previously only available in the internal functionworkpatterns_classify_bw().mingroupargument formgrrel_matrix()Checks
roxygen2::roxygenise()has been run prior to merging to ensure that.RdandNAMESPACEfiles are up to date.Notes
This fixes #31, #58, #59, and #60.