Skip to content

Feature: working patterns and flexibility index#55

Merged
martinctc merged 16 commits into
mainfrom
feature/working-patterns-and-flexibility-score
Feb 3, 2021
Merged

Feature: working patterns and flexibility index#55
martinctc merged 16 commits into
mainfrom
feature/working-patterns-and-flexibility-score

Conversation

@martinctc

@martinctc martinctc commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

This branch adds the working patterns and flexibility index features to wpa.

Changes

New functions

The following new functions are added in this PR:

  1. workpatterns_classify()
  2. workpatterns_classify_bw()
  3. workpatterns_classify_pav()
  4. workpatterns_report
  5. flex_index()
  6. plot_flex_index()

Other changes

  • Additional checks and minor revisions were performed to make sure that the documentation is up to date.
  • All the functions also now allow dynamic signals, as per Feature: allow dynamic signals for all work patterns functions #56
  • Fixed minor bug with the "plot-area" return option, where white space sometimes appears between the areas of the working patterns segments in an area plot.
  • This also increments the package version to v1.4.0.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • Documentation are complete and in a consistent style to the main package.

Notes

This fixes #56.

@martinctc martinctc self-assigned this Jan 27, 2021
@martinctc martinctc added the enhancement New feature or request label Jan 27, 2021
@martinctc
chore: increment package version
1d373ee 
1.4.0 for release of working patterns
@moralec

moralec commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

Are we waiting to integrate this after we are in CRAN? :)

@martinctc

martinctc commented Jan 29, 2021

Copy link
Copy Markdown
Member Author

Are we waiting to integrate this after we are in CRAN? :)

Yes @moralec - this is now incremented as v1.4.0 as it qualifies as a more significant change to the package. The CRAN process is still undergoing (another re-submission is needed), which will continue under the v1.3.1 banner on #54.

I think there are some other checks are required on this PR, e.g.

  1. Check that all combinations of the code run properly (all variations of arguments).
  2. Check that the ability to accept 'dynamic' signals is working, i.e. ability to use Unscheduled_Calls on top of Emails_sent and IMs_sent

If we want to accelerate the merge, I would suggest only doing 1 and only check for 2 as a new feature request (given all checks pass).

@martinctc martinctc marked this pull request as ready for review February 3, 2021 17:32
@martinctc martinctc merged commit d06893a into main Feb 3, 2021
@martinctc martinctc deleted the feature/working-patterns-and-flexibility-score branch February 3, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@martinctc martinctc

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: allow dynamic signals for all work patterns functions

2 participants

@martinctc @moralec