Skip to content

Fix: general bug fixes and prep for v1.6.4#200

Merged
martinctc merged 15 commits into
mainfrom
fix/general-bug-fixes
Jan 19, 2022
Merged

Fix: general bug fixes and prep for v1.6.4#200
martinctc merged 15 commits into
mainfrom
fix/general-bug-fixes

Conversation

@martinctc

@martinctc martinctc commented Jan 12, 2022

Copy link
Copy Markdown
Member

Summary

This branch fixes some general bugs and prepares the CRAN release for v1.6.4. The output from this pull request is submitted to CRAN.

Changes

The changes made in this PR are:

  1. Made meeting_skim() dynamic - the function will still run even if not all variables are present. (Bug: meeting_skim() returns error if variable not present #198)

  2. Enable text mining functions to accept stopwords argument as a string vector, rather than a data frame (Feature request: stopwords argument input is not intuitive #182)

  3. Better handling of errors due to variable name inconsistency when loading in a Ways of Working Assessment query as opposed to a Standard Person Query (Feature: more informative message if WOWA query detected #201)

  4. Fix wording and spelling on Introduction to Organisational Network Analysis article.

  5. Update README.md, cran-comments.md, and DESCRIPTION.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

Notes

This fixes #182, #198, #201.

@martinctc martinctc self-assigned this Jan 14, 2022
Supporting functions to be inserted into other functions which directly call `Collaboration_hours` or `Instant_Message_hours`
@martinctc martinctc added bug Something isn't working refactor Code that neither fixes a bug nor changes feature labels Jan 19, 2022
@martinctc martinctc marked this pull request as ready for review January 19, 2022 15:33
@martinctc martinctc merged commit fa814c9 into main Jan 19, 2022
@martinctc martinctc deleted the fix/general-bug-fixes branch January 19, 2022 16:13
@martinctc martinctc linked an issue Jan 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactor Code that neither fixes a bug nor changes feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: more informative message if WOWA query detected Feature request: stopwords argument input is not intuitive

1 participant