Skip to content

Bugfix: weight not operational in network_p2p()#184

Merged
martinctc merged 5 commits into
mainfrom
fix/weights-in-network_p2p
Sep 8, 2021
Merged

Bugfix: weight not operational in network_p2p()#184
martinctc merged 5 commits into
mainfrom
fix/weights-in-network_p2p

Conversation

@martinctc

@martinctc martinctc commented Sep 2, 2021

Copy link
Copy Markdown
Member

Summary

This branch fixes the weight issue raised in #181.

Changes

The changes made in this PR are:

  1. Explicitly assigns the weight column to the graph so that the resulting network uses the weight.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

The following communities have been checked to be different when using different weight settings:

Louvain communities

image

Leiden communities

image

Notes

This fixes #181.

@martinctc martinctc self-assigned this Sep 2, 2021
@martinctc martinctc added the bug Something isn't working label Sep 3, 2021
@martinctc martinctc marked this pull request as ready for review September 3, 2021 11:00
@martinctc martinctc merged commit b64b562 into main Sep 8, 2021
@martinctc martinctc deleted the fix/weights-in-network_p2p branch September 8, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weight parameter on network_p2p() does not affect output

1 participant