Feature/1.3.1#17
Merged
Merged
Conversation
Update documentation to make it clear that function now works by string matching, and is dynamic.
Add example for combine_signals which will also work as an integrated test
Add a 'building block' function for company totals to be shown generally when NULL is supplied to the hrvar argument.
Update argument documentation on totals_col
Visual improvements to keymetrics_scan() as per issue #26. Two new functions are exported: us_to_space() and maxmin(), which are used to aid the plotting process.
Global change to title size in plots
References to "Collaboration Assessment" now replaced with "Ways of Working Assessment"
Move maxmin() and us_to_space() to their own R files instead of under keymetrics_scan()
Use us_to_space() where possible for cleaner code
Explicitly specify grDevices import for heat_colours()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds new features for v1.3.1.
Changes
The changes made in this PR are:
combine_signals()to make it clear that it is now completely dynamic and uses string matching to combine hourly signals.totals_col()as a building block function to enable a "total" view when NULL is passed to thehrvarargument on standard analysis functions.keymetrics_scan().maxmin()andus_to_space()as the helper functions withinkeymetrics_scan().theme_wpa_basic().New view of
keymetrics_scan():Check
Note
This fixes #20, #22, and #26.