Feature: enhancements and bug fixes for network_p2p()#149
Merged
Conversation
This is fixed for the ggraph method.
Added new `edge_alpha` argument and flipped default colour scheme from black to white.
This was
linked to
issues
May 18, 2021
Also added checks for leiden installation
This now works for both plotting methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch introduces some enhancements and bug fixes to
network_p2p(), as per issues mentioned on GitHub (#145, #146, #148, #159).Changes
The changes made in this PR are:
legend_poshaving no effect on the legend position (fixed for the 'ggraph' method). (Bug: legend positions not working fornetwork_p2p()#148)network_p2p()to light mode (Bug / Aesthetics:network_p2p()colour scheme issues #146)edge_alphaargument for customization of edge transparency. This also resolves issues of edges not appearing on the console by setting the default to 1, but the argument retains the ability of the user to customize edge transparency (Bug / Aesthetics:network_p2p()colour scheme issues #146).network_p2p(display = "leiden")#145)weightargument to enable users to select custom weights for creating graph. (Feature request: ability to use different weights fornetwork_p2p()#159)Checks
roxygen2::roxygenise()has been run prior to merging to ensure that.RdandNAMESPACEfiles are up to date.NEWS.mdhas been updated.Notes
This fixes #145, #146, #148, and #159.