Bugfix: relax variable name checks to collab_area() #81
Merged
Conversation
Checks of metric names are now made case-insensitive to address #72.
Allow having a NULL view for `collaboration_area()`
collab_area()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch fixes the problem where the variable name checks in
collaboration_area()is overly strict, and resolves it by making it case-sensitive. This branch is a direct fix of issue #72 as raised by @juliajuju93.Changes
The changes made in this PR are:
collaboration_area()case-insensitive.hrvarset toNULL, and adds the ability for it to run it as a total view. This is an extension of Feature: show company total #22 raised by @AinizeCidoncha.Checks
roxygen2::roxygenise()has been run prior to merging to ensure that.RdandNAMESPACEfiles are up to date.Notes
This fixes #72.