Bug Fix: reading double-byte characters in import_wpa()#76
Merged
Conversation
Added the ability to specify encoding for `import_wpa()`. The new default used is 'UTF-8'.
|
Very spot-on fix! Thank you for acting so promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch added the ability to specify encoding for
import_wpa(). The new default used is 'UTF-8'.Changes
The changes made in this PR are:
encodinginimport_wpa(). This feature feeds onto the underlyingdata.table::fread()function. The default is changed to 'UTF-8' to work with double-byte characters.This has been tested with some dummy data and works:
Checks
roxygen2::roxygenise()has been run prior to merging to ensure that.RdandNAMESPACEfiles are up to date.Notes
This fixes #73.