Skip to content

Feature: create identify_shifts_wp()#66

Merged
moralec merged 2 commits into
mainfrom
feature/identify_shifts_wp
Feb 25, 2021
Merged

Feature: create identify_shifts_wp()#66
moralec merged 2 commits into
mainfrom
feature/identify_shifts_wp

Conversation

@martinctc

Copy link
Copy Markdown
Member

Summary

This branch adds a new function identify_shifts_wp(), which computes the 'real' work shifts based on binary activity. This is distinct from identify_shifts(), which uses Outlook settings to count the number of distinct work shifts. The outputs of the two functions can be compared. to measure the accuracy of existing Outlook settings.

Changes

The changes made in this PR are:

  1. Added identify_shifts_wp()

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.

@martinctc martinctc self-assigned this Feb 15, 2021
@martinctc martinctc added the enhancement New feature or request label Feb 15, 2021
@martinctc martinctc requested a review from moralec February 15, 2021 18:08

@moralec moralec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@moralec moralec merged commit 6ce6eb9 into main Feb 25, 2021
@moralec moralec deleted the feature/identify_shifts_wp branch February 25, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants