Eagerly convert from and to data.table and patch v1.8.1#233
Merged
Conversation
11 tasks
Member
|
Thanks @DavisVaughan ! Can I just check - would this block the release of tidyr? i.e. would we need to fix and release this to CRAN in order for tidyr to release? |
Contributor
Author
|
No, we have already sent tidyr in. Normally we try to give you 2 weeks to fix it before we send the package in. Unfortunately we couldn't do that for you this time. We probably just missed wpa somehow when looking at the list of broken revdeps. |
Member
|
Thank you! Managed to pass the checks - failed checks were due to the GitHub Action for R-CMD-Checks using an outdated branch name, now rectified. Will submit to CRAN and merge to |
v1.8.1
Member
|
Update released to CRAN. Thanks again @DavisVaughan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
We ran revdeps for the upcoming release of tidyr 1.3.0 and your package came up.
In dev tidyr we have reworked the way that data frame "restoration" is done in a number of the tidyr verbs to be simpler, more robust, and resolve a number of edge case issues. Unfortunately for wpa, this means that the data.table class is no longer preserved in a place where it was expected to be. I've fixed that with an explicit
as.data.table()call.We actually plan to release tidyr today. I'm not sure how wpa slipped through the cracks when we ran revdeps a few weeks ago. I'm sorry about that!
This patch is backwards compatible with CRAN tidyr.
Thanks!