Skip to content

Feature: improve error handling on IV functions#157

Merged
martinctc merged 4 commits into
mainfrom
refactor/streamline-iv-functions
Jun 16, 2021
Merged

Feature: improve error handling on IV functions#157
martinctc merged 4 commits into
mainfrom
refactor/streamline-iv-functions

Conversation

@martinctc

@martinctc martinctc commented Jun 16, 2021

Copy link
Copy Markdown
Member

Summary

This branch improves error handling on IV functions, especially in relation to predictors in which their p-values fall below the required significance level set at siglevel. A new argument exc_sig has been added.

Changes

The changes made in this PR are:

  1. Added argument exc_sig to create_IV()
  2. Added error message if no predictors are left after predictors have been filtered out.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

@martinctc martinctc added the enhancement New feature or request label Jun 16, 2021
@martinctc martinctc self-assigned this Jun 16, 2021
@martinctc martinctc marked this pull request as ready for review June 16, 2021 15:32
@martinctc martinctc merged commit 464700d into main Jun 16, 2021
@martinctc martinctc deleted the refactor/streamline-iv-functions branch June 16, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant