Skip to content

Feature: improve return outputs of working patterns functions#130

Merged
martinctc merged 5 commits into
mainfrom
feature/improve-working-patterns
Apr 13, 2021
Merged

Feature: improve return outputs of working patterns functions#130
martinctc merged 5 commits into
mainfrom
feature/improve-working-patterns

Conversation

@martinctc

@martinctc martinctc commented Apr 13, 2021

Copy link
Copy Markdown
Member

Summary

This branch makes improvement to some outputs of working patterns functions.

Changes

The changes made in this PR are:

  1. Made possible for the "data" return option for workpatterns_classify_bw() to return HR attributes. (Feature request: return HR attribute for workpatterns_classify() when returning "data" #129)
  2. Removed the confusing Signals.Total.x and Signals.Total.y which is resulted from a duplicate column when performing a joining between datasets for workpatterns_classify_bw().
  3. Added documentation of definitions for working patterns. (Documentation: add definitions for working patterns archetypes #124)
  4. Removed package version number from start-up message to avoid inconsistency.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.

Notes

This fixes #124 and #129.

Fixed an issue for `workpatterns_classify()`
@martinctc martinctc self-assigned this Apr 13, 2021
@martinctc martinctc added enhancement New feature or request refactor Code that neither fixes a bug nor changes feature labels Apr 13, 2021
@martinctc martinctc merged commit 7a87743 into main Apr 13, 2021
@martinctc martinctc deleted the feature/improve-working-patterns branch April 13, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Code that neither fixes a bug nor changes feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: add definitions for working patterns archetypes

1 participant