Skip to content

Feedback should not be searching by package name #13

New issue
New issue
Closed
Feature
#29
Closed
Feedback should not be searching by package name#13
Feature
#29
Labels
Issue-FeatureThis is a feature request
@ThomasNieto

Description

@ThomasNieto
ThomasNieto
opened on Jul 27, 2024

Feedback returns false positives due to the feedback provider searching via package name. It really should only use the WinGet command search and maybe moniker. In the current form your users not trust your results due to the lenient searching.

winget-command-not-found/src/WinGetCommandNotFoundFeedbackPredictor.cs

Lines 178 to 191 in 9bc8361

// 2) No matches found,
// search by name
ps.Commands.Clear();
pkgList = ps.AddCommand("Find-WinGetPackage")
.AddParameter("Name", query)
.AddParameter("MatchOption", "ContainsCaseInsensitive")
.AddParameters(common)
.Invoke();
if (pkgList.Count > 0)
{
tooManySuggestions = pkgList.Count > _maxSuggestions;
packageMatchFilterField = "name";
return pkgList;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-FeatureThis is a feature request

    Type

    Feature

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions