Fix crash due to static weak pointer referencing an object in an unloaded DLL#5474
Merged
JohnMcPMS merged 2 commits intomicrosoft:masterfrom May 27, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@Fulgen301 Awesome, thanks for fixing this. I was just turning the corner to work on bug fixes and now there is one fewer on my list. |
yao-msft
reviewed
May 22, 2025
| }; | ||
|
|
||
| std::weak_ptr<CachedInstalledIndex> m_weak; | ||
| winrt::slim_mutex m_lock; |
Contributor
There was a problem hiding this comment.
nit: everything except Get() can go to private: section?
Member
There was a problem hiding this comment.
This is a "private" struct anyway, being declared in the .cpp.
JohnMcPMS
approved these changes
May 23, 2025
Member
Shot myself in the foot by being helpful with the spelling... @yao-msft, could you please help out? |
yao-msft
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://devblogs.microsoft.com/oldnewthing/20210215-00/
Fixes #5363.
Microsoft Reviewers: Open in CodeFlow