Skip to content

Build a WebView2 sample with the WinRT APIs#647

Merged
rylev merged 11 commits intomicrosoft:masterfrom
wravery:webview2-example
Mar 27, 2021
Merged

Build a WebView2 sample with the WinRT APIs#647
rylev merged 11 commits intomicrosoft:masterfrom
wravery:webview2-example

Conversation

@wravery
Copy link
Copy Markdown
Collaborator

@wravery wravery commented Mar 26, 2021

Fixes #538

Copy link
Copy Markdown
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! ♥ I just have some questions and comments.

Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs
Comment thread examples/webview2/src/main.rs Outdated
@kennykerr kennykerr mentioned this pull request Mar 26, 2021
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/bindings/build.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
Comment thread examples/webview2/src/main.rs Outdated
@wravery wravery requested a review from rylev March 26, 2021 20:04
Copy link
Copy Markdown
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@wravery wravery closed this Mar 27, 2021
@wravery wravery reopened this Mar 27, 2021
@wravery
Copy link
Copy Markdown
Collaborator Author

wravery commented Mar 27, 2021

Oops, that close button is too easy to hit in the GitHub mobile app. 😆

@rylev rylev merged commit 81491f8 into microsoft:master Mar 27, 2021
@wravery wravery deleted the webview2-example branch March 27, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WebView2 sample

3 participants