Remove "riddle" and metadata generation#3266
Merged
Conversation
ChrisDenton
reviewed
Sep 9, 2024
Collaborator
ChrisDenton
left a comment
There was a problem hiding this comment.
It's unfortunate but completely understandable. I'd much rather the focus be on what's most important right now than spread your efforts too thin.
Do we need one last update to the riddle crate that notes that it's no longer being updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to streamline and focus on what's most valuable, I'm making the difficult decision to drop support for metadata generation in general. While the existing metadata generation tooling is not ideal for Rust developers (e.g. midlrt and win32metadata), I don't realistically have the bandwidth to provide a Rust version any time soon. I would rather spend what effort I can on what the
windows-rsproject does best which is to support generation of Rust bindings and type system support. The benefit in removing this code is that I can then streamline the implementation ofwindows-bindgenand more rapidly improve type system and authoring support without being encumbered by the future possibility of metadata generation. Perhaps in future I'll have the bandwidth to tackle this again, but it doesn't seem likely in the short term.Fixes: #1093