Surface engine failures in waza suggest#330
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix waza suggest to surface real engine errors
Surface engine failures in Jun 16, 2026
waza suggest
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves waza suggest error reporting by detecting engine-level failures (via ExecutionResponse.Success / ErrorMsg) before attempting to parse model output, avoiding misleading YAML parse errors. It also adds a distinct error for empty suggest responses and extends tests to prevent regressions.
Changes:
- Check
ExecutionResponse.Successafter grader-selection (pass 1) and eval-generation (pass 2) and return the engine error message early. - Treat empty model output as a distinct parsing error (
empty suggest response) while preserving existing invalid-YAML behavior for non-empty malformed output. - Add regression tests covering pass-1 failure, pass-2 failure, and empty suggest responses.
Show a summary per file
| File | Description |
|---|---|
| internal/suggest/suggest.go | Adds engine failure detection before parsing and introduces distinct empty-response parsing behavior. |
| internal/suggest/suggest_test.go | Adds regression tests for engine failures in both passes and for empty suggest responses. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This was referenced Jun 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waza suggestwas parsing empty output after engine-level failures and reporting a misleading YAML error. The actual failure was already present inExecutionResponse.ErrorMsgbut was ignored.ExecutionResponse.Successafter both suggest passes:Parse diagnostics
empty suggest response.Regression coverage