ci: Deploy Pages after release workflow#265
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Pages deployment pipeline so the documentation site can be rebuilt and deployed after a successful tag-based release, and updates the Pages workflow runtime to Node 22 to satisfy the current Astro requirements.
Changes:
- Trigger
.github/workflows/pages.ymlviaworkflow_runafter theReleaseworkflow completes successfully (in addition to existing push/manual triggers). - Update the Pages workflow Node version to 22.
- Document the Pages deploy as part of the release pipeline in
docs/RELEASE.md.
Show a summary per file
| File | Description |
|---|---|
| docs/RELEASE.md | Documents Pages deployment as an additional step in the release pipeline. |
| .github/workflows/pages.yml | Triggers Pages deploy after successful Release workflow completion and updates Node version for Astro compatibility. |
Copilot's findings
Comments suppressed due to low confidence (1)
.github/workflows/pages.yml:28
- Because this workflow now triggers via
workflow_runafter a tag-based Release,actions/checkoutwill default to the repository default branch HEAD (not necessarily the commit/tag that produced the Release). That can publish a site build that doesn’t correspond to the released tag ifmainadvances before Pages runs. Consider checking outgithub.event.workflow_run.head_sha(with a fallback for non-workflow_runevents) so the deployed site is built from the same revision as the Release run.
if: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
name: Build
steps:
- name: Checkout
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releaseworkflow completes successfully, so release-site updates are published even when the main push path filter does not trigger.>=22.12.0).Validation
.github/workflows/pages.ymlwith Ruby YAML parser.