fix: remove nonstandard skill type prompt#261
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the non-standard “skill type” prompt/metadata from waza new skill so newly scaffolded skills align with the agent skills spec (no type: frontmatter).
Changes:
- Removes
SkillTypeand the “Skill type” wizard question; stops renderingtype:in wizard-generatedSKILL.md. - Removes
type:from non-interactive defaultSKILL.mdscaffolding. - Updates docs and tests to reflect spec-aligned skill metadata.
Show a summary per file
| File | Description |
|---|---|
| site/src/content/docs/reference/cli.mdx | Updates CLI docs to describe spec-aligned wizard metadata collection (no skill type). |
| site/src/content/docs/getting-started.mdx | Removes type: from the getting-started SKILL.md example. |
| README.md | Updates waza new skill description to reflect spec-aligned wizard fields. |
| internal/wizard/wizard.go | Removes SkillType and type: template emission; removes the wizard “Skill type” select. |
| internal/wizard/wizard_test.go | Updates wizard/template tests to assert type: is not generated and removes type-related wizard input. |
| docs/GUIDE.md | Updates guide copy to reflect spec-aligned wizard metadata collection. |
| docs/GETTING-STARTED.md | Removes type: from the getting-started SKILL.md example. |
| cmd/waza/cmd_new.go | Removes type: from non-interactive default SKILL.md scaffold content. |
| cmd/waza/cmd_new_test.go | Updates scaffold tests to assert new SKILL.md does not contain type:. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 2
…tion Ensure callers always receive an error instead of a zero-value SkillSpec when the form exits early (EOF / non-TTY mode) without populating the required name or description fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment on lines
120
to
124
| func TestRunSkillWizard_InitialName(t *testing.T) { | ||
| // When initialName is provided, the name field is pre-populated. | ||
| // User submits the pre-populated name and fills in other fields. | ||
| in := pipeInput(t, "azure-deploy", "My pre-named skill", "use for testing", "", "1") | ||
| in := pipeInput(t, "azure-deploy", "My pre-named skill", "use for testing", "") | ||
| out := &bytes.Buffer{} |
This was referenced May 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243
Summary
waza new skillinteractive wizard.type:frontmatter in new skill scaffolds.Validation
go test ./internal/wizard ./cmd/wazago test ./...cd site && npm run buildNote:
golangci-lintwas not available in this environment.