Skip to content

fix: detect SKILL body routing markers#236

Merged
github-actions[bot] merged 1 commit into
microsoft:mainfrom
drvoss:squad/223-heuristic-scorer-body-triggers
May 20, 2026
Merged

fix: detect SKILL body routing markers#236
github-actions[bot] merged 1 commit into
microsoft:mainfrom
drvoss:squad/223-heuristic-scorer-body-triggers

Conversation

@drvoss

@drvoss drvoss commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • detect compliance trigger, anti-trigger, and routing markers in SKILL.md body as well as frontmatter description
  • include body sections in trigger and anti-trigger counts
  • add a regression test covering body-only routing sections

Closes #223

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@drvoss drvoss requested a review from spboyer as a code owner May 13, 2026 23:36
@github-actions github-actions Bot enabled auto-merge (squash) May 13, 2026 23:37

@spboyer spboyer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean — no issues found. LGTM.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@cdb3899). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage        ?   75.73%           
=======================================
  Files           ?      152           
  Lines           ?    17498           
  Branches        ?        0           
=======================================
  Hits            ?    13252           
  Misses          ?     3331           
  Partials        ?      915           
Flag Coverage Δ
go-implementation 75.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot merged commit 1bdc69d into microsoft:main May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HeuristicScorer only checks frontmatter description for triggers — ignores SKILL.md body

3 participants