fix: waza serve crashes when stdin is not a terminal#224
Merged
Conversation
The MCP stdio server starts unconditionally alongside the HTTP dashboard server. When waza serve runs in the background or with piped/closed stdin, the MCP reader hits EOF and crashes the entire process — killing the HTTP server. Fix: only start MCP stdio when stdin is a terminal (term.IsTerminal). The HTTP dashboard works independently without MCP. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP stdio server crashed when stdin wasn't a terminal (background mode, piped input), killing the HTTP dashboard server. Now only starts MCP stdio when
term.IsTerminal()is true.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com