fix: CI integration test allows eval failures with mock executor#210
Merged
Conversation
The integration test step runs `waza run` with the mock executor, which produces generic output that won't match output_contains expectations. This is expected — the test validates that waza completes without crashing, not that mock evals pass. Root cause: PR #203 (v0.27.0) wired up evaluateExpectations() which made output_contains checks actually execute. Before that, these fields were defined but never evaluated, so the integration test passed silently. Exit code 1 (eval failures) is now allowed. Exit codes >1 (crashes, panics) still fail CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: PR #203 (v0.27.0) wired up
evaluateExpectations()which madeoutput_containschecks actually execute. Before that, these fields were defined but never evaluated — the integration test passed because expectations were silently skipped.The mock executor outputs
Mock response for: {prompt}which doesn't contain keywords likerecursive,factorial,async, etc. that the example tasks expect. This is correct behavior — the test validates waza runs without crashing, not that mock evals pass.Fix: Exit code 1 (eval failures) is now allowed. Exit codes >1 (crashes, panics) still fail CI.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com