-
Notifications
You must be signed in to change notification settings - Fork 102
Support the BuiltTools SKU #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
✅ Build vswhere 1.0.18-beta+g7867f84655 completed (commit 7867f84655 by @refack) |
heaths
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is intentional, and why you can - and must - pass the value to the -products parameter. A new build will be out soon that printed usage and I'll add examples in the wiki soon.
|
Should also mention that the defaults are VS because that is the main use case for vswhere. |
|
IMHO you should add 'BuildTools' as a use case since that would make |
|
It is. Pass it to the -products command line switch. New version with -help support and more just went up. The installer installs lots of products and more will be added. The default use case is VS (very different composition than built tools) but it was always my goal to support all products, hence the switch. |
|
I still think vswhere not finding the build tools is the wrong approach. I want to move away from VS2015 but vswhere brakes the command line tools for CMake for me in the CI. |
|
It wasn't necessary when originally spec'd, and Build Tools back then was missing a lot of tools (compilers, etc.) that VS had. Changing what it detects after it had been out for a long time would be a breaking change to many build systems, hence having to opt into detecting it which you can easily do with the To reiterate before I close this thread: we cannot responsibility change the detection to include Build Tools by default or it will be a breaking behavioral change. |
No description provided.