Skip to content

Conversation

@refack
Copy link

@refack refack commented Feb 24, 2017

No description provided.

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@AppVeyorBot
Copy link

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is intentional, and why you can - and must - pass the value to the -products parameter. A new build will be out soon that printed usage and I'll add examples in the wiki soon.

@heaths heaths closed this Feb 24, 2017
@heaths
Copy link
Member

heaths commented Feb 24, 2017

Should also mention that the defaults are VS because that is the main use case for vswhere.

@refack
Copy link
Author

refack commented Feb 24, 2017

IMHO you should add 'BuildTools' as a use case since that would make vswhere a welcome companion to the "CLI" compatible tool-set.

@heaths
Copy link
Member

heaths commented Feb 24, 2017

It is. Pass it to the -products command line switch. New version with -help support and more just went up.

The installer installs lots of products and more will be added. The default use case is VS (very different composition than built tools) but it was always my goal to support all products, hence the switch.

@ericoporto
Copy link

ericoporto commented Jan 19, 2022

I still think vswhere not finding the build tools is the wrong approach. I want to move away from VS2015 but vswhere brakes the command line tools for CMake for me in the CI.

@heaths
Copy link
Member

heaths commented Jan 19, 2022

It wasn't necessary when originally spec'd, and Build Tools back then was missing a lot of tools (compilers, etc.) that VS had. Changing what it detects after it had been out for a long time would be a breaking change to many build systems, hence having to opt into detecting it which you can easily do with the -products parameter.

To reiterate before I close this thread: we cannot responsibility change the detection to include Build Tools by default or it will be a breaking behavioral change.

@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants