@nohwnd I'm looking at this PR:
#2557
Currently the problem I'm seeing in #2952 is this output from MSBuild:
Build FAILED.
0 Warning(s)
0 Error(s)
This is because the test host crashed, but we don't have any further info.
We should never, ever, ever see this output from MSBuild. The MSBuild team added the check to prevent this that #2557 is disabling using reflection.
I'm thinking of another way of fixing this, which is check the result that we're about to return, and if we're returning false, log an error always. Or find a way to thread through the error to the VSTestTask and log it properly. But just in case I'd always log even a dummy error such as "Test run failed", to ensure that MSBuild doesn't fail but report 0 errors.
@nohwnd I'm looking at this PR:
#2557
Currently the problem I'm seeing in #2952 is this output from MSBuild:
This is because the test host crashed, but we don't have any further info.
We should never, ever, ever see this output from MSBuild. The MSBuild team added the check to prevent this that #2557 is disabling using reflection.
I'm thinking of another way of fixing this, which is check the result that we're about to return, and if we're returning false, log an error always. Or find a way to thread through the error to the
VSTestTaskand log it properly. But just in case I'd always log even a dummy error such as "Test run failed", to ensure that MSBuild doesn't fail but report 0 errors.