Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Update attribute options typings#364

Merged
hawkticehurst merged 4 commits into
microsoft:mainfrom
hawkticehurst:update-attribute-options-typings
Mar 28, 2022
Merged

Update attribute options typings#364
hawkticehurst merged 4 commits into
microsoft:mainfrom
hawkticehurst:update-attribute-options-typings

Conversation

@hawkticehurst

@hawkticehurst hawkticehurst commented Mar 28, 2022

Copy link
Copy Markdown
Member

Link to relevant issue

This pull request resolves #325

Description of changes

Pulls in an upstream change from FAST Foundation that resolves an issue where some of the React toolkit components were forced to use enums when defining a handful of attribute values.

This fix now allows all React components to use literal string values when defining attributes.

Also updates the React component docs to reflect this change.

@hawkticehurst hawkticehurst merged commit 3ba7054 into microsoft:main Mar 28, 2022
@hawkticehurst hawkticehurst deleted the update-attribute-options-typings branch March 28, 2022 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum types potentially too strict

1 participant