(#868) publish option --skip-duplicate doesn't consider target platforms#873
Merged
joaomoreno merged 1 commit intoJul 11, 2023
Conversation
If there is a target present in the options, then check it along with the version. Otherwise just check the version.
mbehr1
reviewed
Jun 21, 2023
mbehr1
left a comment
There was a problem hiding this comment.
thx! Lgtm. Didn't test it yet but code looks good/makes sense.
Contributor
Author
|
Hi all, any updates on this one? This will be very helpful for our publishing workflow. |
joaomoreno
approved these changes
Jul 11, 2023
alexdima
approved these changes
Jul 11, 2023
Contributor
Author
|
Thanks all! 🥳 |
Member
|
No... thank YOU @drewbrokke! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #868
Problem:
When publishing multiple
vsixpackages with different target platforms using the--packagePathflag and the--skip-duplicateflag, only the first package is published. After that, all the others are considered duplicate versions and are not published.Solution:
Always consider the target platform along with the version when the
targetis present in the publish optionsI did not see any relevant test cases for this code, so please let me know if I missed it and I will update the PR.
Thanks!
FYI @mbehr1