feat: sanity check to validate entrypoints#669
Merged
joaomoreno merged 8 commits intomicrosoft:mainfrom Dec 31, 2021
joerohde:main
Merged
feat: sanity check to validate entrypoints#669joaomoreno merged 8 commits intomicrosoft:mainfrom joerohde:main
joaomoreno merged 8 commits intomicrosoft:mainfrom
joerohde:main
Conversation
- For 'main' and 'browser' keys in package.json verify the files will be copied into the vsix.
joaomoreno
approved these changes
Dec 31, 2021
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
With entrypoints 'main' and browser' it's increasingly possible to not have an entrypoint setup for packaging. The chances increase since there tends to be a lot of refactoring to support both runtime environments.
This PR adds a quick check via a *Processor class to make sure that any entrypoint declared in the package is actually going to be present in the
extensionfolder of the vsix.Tests consistent with package.test.ts have been added.