fix: docker base image needs be at latest node:14-alpine#651
Merged
joaomoreno merged 3 commits intomicrosoft:mainfrom Jan 3, 2022
hangxingliu:main
Merged
fix: docker base image needs be at latest node:14-alpine#651joaomoreno merged 3 commits intomicrosoft:mainfrom hangxingliu:main
node:14-alpine#651joaomoreno merged 3 commits intomicrosoft:mainfrom
hangxingliu:main
Conversation
|
@joaomoreno Do you have any concerns? |
|
🎉 This PR is included in version 2.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tested use this tools in Docker yesterday and I got the error output:
/opt/vsce/out/package.js:136 return (translations ?? []) ^ SyntaxError: Unexpected token '?' at wrapSafe (internal/modules/cjs/loader.js:915:16) at Module._compile (internal/modules/cjs/loader.js:963:27) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10) at Module.load (internal/modules/cjs/loader.js:863:32) at Function.Module._load (internal/modules/cjs/loader.js:708:14) at Module.require (internal/modules/cjs/loader.js:887:19) at require (internal/modules/cjs/helpers.js:74:18) at Object.<anonymous> (/opt/vsce/out/main.js:27:19) at Module._compile (internal/modules/cjs/loader.js:999:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)After I read the document and source codes. I found the Node.js version in the
Dockerfileis not suitable for the requirement in the README file.So I updated it from
12to14.Thanks.