Add ability to publish using 'npm version'#263
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jun 4, 2018
JimiC:publish-using-npm-version
Merged
Add ability to publish using 'npm version'#263joaomoreno merged 1 commit intomicrosoft:masterfrom JimiC:publish-using-npm-version
joaomoreno merged 1 commit intomicrosoft:masterfrom
JimiC:publish-using-npm-version
Conversation
Member
|
Works great for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #206
References #180
As per popular request
vsce publish <version>will now usenpm version <version>, in order to bump the package version. In the process,package-lock.jsonwill also be updated (when usingnpm5+) and taggedgitcommit will be done (supportinggpgsigning when it's set ingitconfig).Note: As before only
major,minorandpatchare supported as a valid<version>.I refrained from implementing a rollback of the process, as if anything goes wrong after the version bump (i.e. network issues), the user can simply execute
vsce publish(without<version>) and complete the publishing.This implementation also does not interfere with using plain
vsce publishvia a CI service. The user, in that case, should performnpm version <version>locally. Then push the commit and the tag. The CI publishing stage should only callvsce publish -p <token>.