Support Yarn use in package command#260
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom May 3, 2018
Merged
Conversation
This fixes an issue where `npm list` thinks dependencies are invalid, but a project uses Yarn and this can correctly handle the dependencies. This is blocking SQL Ops Studio extensions that rely on https://github.com/anthonydresser/dataprotocol-client, as this is marked as invalid and essentially requires use of Yarn.
Member
|
Looks great, thanks! v1.40.0 is on the way of being built: https://travis-ci.org/Microsoft/vscode-vsce/builds/374278813. Let me know how it goes for you. |
Contributor
Author
|
Works great, thanks for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
npm listthinks dependencies are invalid,but a project uses Yarn and this can correctly handle the dependencies.
This is blocking SQL Ops Studio extensions that rely on
https://github.com/anthonydresser/dataprotocol-client, as this is marked
as invalid and essentially requires use of Yarn.
Please let me know if there's anything I should be doing in terms of testing etc. to help validate this. The basic test of using
vsce package --yarnworked as expected and no longer caused packaging to fail.