Skip to content

Quote filename value in Content-Disposition header#1060

Merged
sandy081 merged 1 commit intomicrosoft:mainfrom
dtivel:quote-filename
Sep 30, 2024
Merged

Quote filename value in Content-Disposition header#1060
sandy081 merged 1 commit intomicrosoft:mainfrom
dtivel:quote-filename

Conversation

@dtivel
Copy link
Copy Markdown
Member

@dtivel dtivel commented Sep 27, 2024

Resolve #1059.

This change quotes the filename value of the Content-Disposition header to ensure that file names with special characters are handled properly.

CC @sandy081, @sbanni

@benibenj benibenj requested a review from sandy081 September 30, 2024 06:46
@sandy081
Copy link
Copy Markdown
Member

@dtivel Thanks for the fix

@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing signed extension fails if file name contains special character

3 participants