This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Merged
Conversation
|
Looking forward to this being merged in. |
Member
|
@YuichiNukiyama thanks 🌷 for the PR . I've published it as part of vscode-tslint 0.8.1. I've changed the default to false, since users where confused that tslint is active by default on .js files. We should revisit the implementation once the language server protocol 3.0 is out. With this protocol version we can dynamically change the configuration so that .js files are not synchronized to the server, when jsEnabled is set to false. The current implementation always syncs over the JS files and then just ignores them when jsEnabled is set to false. |
Member
|
@jacobbogers what issue do you exactly refer to? The PR is about enabling a jsEnable option and this is in place since a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #149