Improve endless loop detection #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For BeginEnd and BeginWhile rules, improves the endless loop detection, detecting multiple rule deep loops and not falsing detecting successively repeating rules that did not occur at the same place. Fixes microsoft#145.
alexdima
reviewed
Jan 27, 2021
Member
alexdima
left a comment
There was a problem hiding this comment.
I need to think more about this test case and if it is possible to avoid the while loop through the stack elements.
…ered at the same position
Member
|
Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presenting a solution for endless loop detection that catches endless loops that occur over multiple Begin/End or Begin/While rules, while preventing falsely flagging rules that appear to be endless loops due to the same rule as last stacked matching with a zero length capture condition.
Included are tests for the possible endless loop patterns and for the false pattern described above.
Fixes #145