Skip to content

fix: avoid 'Invalid extraction directory' when unzipping#303

Merged
connor4312 merged 1 commit intomicrosoft:mainfrom
SKaplanOfficial:fix-unzip-invalid-directory
Mar 18, 2025
Merged

fix: avoid 'Invalid extraction directory' when unzipping#303
connor4312 merged 1 commit intomicrosoft:mainfrom
SKaplanOfficial:fix-unzip-invalid-directory

Conversation

@SKaplanOfficial
Copy link
Contributor

@SKaplanOfficial SKaplanOfficial commented Mar 18, 2025 •
edited
Loading

Added a line that ensures extractDir exists before attempting to unzip to it on macOS and Linux platforms. On macOS version 15.3.2, unzip does not create intermediate directories. Based on some brief research, this seems to be the case for at least some Linux varieties as well.

This was causing an Invalid extraction directory error to occur every time I tried to debug a VSCode extension using the test-cli. The error occurs even for a freshly made project using npx --package yo --package generator-code -- yo code:

steven@MacBookPro vscode-unzip-test % npx vscode-test
✔ Validated version: 1.98.2
✔ Found at https://update.code.visualstudio.com/1.98.2/darwin-arm64/stable?released=true
⠋ Downloading VS Code: 129.25/131.43MB (98%)Invalid extraction directory
✖ Error downloading, retrying (attempt 1 of 3): Failed to unzip archive, exited with 10
✔ Found at https://update.code.visualstudio.com/1.98.2/darwin-arm64/stable?released=true
⠏ Downloading VS Code: 129.68/131.43MB (99%)Invalid extraction directory
✖ Error downloading, retrying (attempt 3 of 3): Failed to unzip archive, exited with 10
✔ Found at https://update.code.visualstudio.com/1.98.2/darwin-arm64/stable?released=true
⠏ Downloading VS Code: 131.17/131.43MB (100%)Invalid extraction directory
✖ Error: Error: Failed to unzip archive, exited with 10
Error: Failed to download and unzip VS Code 1.98.2
    at download (/Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-electron/out/download.js:396:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async downloadAndUnzipVSCode (/Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-electron/out/download.js:409:12)
    at async Module.runTests (/Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-electron/out/runTest.js:42:40)
    at async PreparedDesktopRun.run (file:///Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-cli/out/cli/platform/desktop.mjs:74:20)
    at async runPreparedConfigs (file:///Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-cli/out/bin.mjs:118:31)
    at async main (file:///Users/steven/Projects/vscode-unzip-test/node_modules/@vscode/test-cli/out/bin.mjs:34:20)

Edit: The error also occurs when using the sample provided in this repo, so it's not an upstream issue.

Furthermore, upon cloning this repository, 8 of the tests were failing every time.

Without Fix: 8 Tests Failing without-fix

After this change, all tests consistently pass:

with-fix

@SKaplanOfficial
Fix for 'Invalid extraction directory' on macOS
6558ae1 
Added a line that ensures `extractDir` exists before attempting to unzip to it.
@connor4312 connor4312 enabled auto-merge (squash) March 18, 2025 14:53
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 18, 2025
@connor4312 connor4312 merged commit 70040b7 into microsoft:main Mar 18, 2025
2 checks passed
@SKaplanOfficial SKaplanOfficial deleted the fix-unzip-invalid-directory branch March 18, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connor4312 connor4312 connor4312 approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

March 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@SKaplanOfficial @connor4312 @chrmarti