This repository was archived by the owner on Nov 16, 2023. It is now read-only.
show type hierarchy#71
Merged
Merged
Conversation
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Eskibear
commented
Aug 26, 2021
|
|
||
|
|
||
| export const enum TypeHierarchyDirection { | ||
| Subtypes = 'subtypes', |
Member
Author
There was a problem hiding this comment.
different from call-hierarchy, I use string enum here.
Eskibear
commented
Aug 26, 2021
| 'symbol-event', 'symbol-operator', 'symbol-type-parameter' | ||
| ]; | ||
|
|
||
| export function getThemeIcon(kind: vscode.SymbolKind): vscode.ThemeIcon | undefined { |
Member
Author
There was a problem hiding this comment.
I extract it here, as it's shared between call-h and type-h.
Eskibear
commented
Aug 26, 2021
|
|
||
| private static _key = 'references-view.typeHierarchyMode'; | ||
|
|
||
| private _ctxMode = new ContextKey<TypeHierarchyDirection>('references-view.typeHierarchyMode'); |
Member
Author
There was a problem hiding this comment.
different from call-h, I directly save value of corresponding enum string into memento object for simplicity.
Member
Author
|
Here is a test with the same mock extension mentioned in microsoft/vscode#130922 (comment) show-type-hierarchy.mp4 |
This comment has been minimized.
This comment has been minimized.
jrieken
reviewed
Sep 3, 2021
jrieken
left a comment
Contributor
There was a problem hiding this comment.
lgtm, pushed a commit to change the spelling to 'supertypes'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of microsoft/vscode#15533
The implementation is mostly copied from call hierarchy.