Fix getAllInterpreters API by always triggering discovery as part of activation
#17499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Sep 22, 2021
getAllInterpreters API by always trigger discovery as part of activation
getAllInterpreters API by always trigger discovery as part of activationgetAllInterpreters API by always triggering discovery as part of activation
|
This didn't seem to fix the bug. It still doesn't get the list. |
rchiodo
requested changes
Sep 22, 2021
rchiodo
left a comment
There was a problem hiding this comment.
Discovery might still not be finished when jupyter asks? Jupyter is the one to load the python extension and it is probably doing this as it's requesting the kernels.
Author
|
@rchiodo I have merged both the fixes in this branch. |
|
Thanks, building the vsix now |
rchiodo
approved these changes
Sep 22, 2021
|
Latest after merge works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17492