Skip to content

Interactive Window input box tweaks #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IanMatthewHuff merged 5 commits into from
Feb 10, 2020
Merged

Interactive Window input box tweaks #10029

IanMatthewHuff merged 5 commits into from
Feb 10, 2020

Conversation

@IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Feb 10, 2020

For #9282

Doing 1, 5, and 6 from the VSCode list.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

IanMatthewHuff
IanMatthewHuff commented Feb 10, 2020
View reviewed changes
src/datascience-ui/interactive-common/redux/reducers/commonEffects.ts
...arg.prevState,
activateCount: arg.prevState.activateCount + 1
};
return focusPending(arg.prevState);
Copy link
Member Author

@IanMatthewHuff IanMatthewHuff Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both do the same thing currently, but I was keeping them as they represent different actions.

@IanMatthewHuff IanMatthewHuff requested review from DavidKutu, DonJayamanne and rchiodo and removed request for DonJayamanne February 10, 2020 21:29
rchiodo
rchiodo approved these changes Feb 10, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-io
Copy link

codecov-io commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #10029 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10029      +/-   ##
==========================================
- Coverage   61.19%   61.17%   -0.02%     
==========================================
  Files         564      564              
  Lines       30147    30173      +26     
  Branches     4561     4567       +6     
==========================================
+ Hits        18448    18458      +10     
- Misses      10667    10680      +13     
- Partials     1032     1035       +3
Impacted Files Coverage Δ
src/datascience-ui/interactive-common/mainState.ts 61.97% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterNotebook.ts 4.38% <0%> (-0.18%) ⬇️
...ient/datascience/interactive-ipynb/nativeEditor.ts 56.86% <0%> (-0.13%) ⬇️
src/client/constants.ts 80% <0%> (ø) ⬆️
src/client/common/platform/fileSystem.ts 77.21% <0%> (+1.78%) ⬆️
src/client/sourceMapSupport.ts 80.43% <0%> (+2.17%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead69d5...7f9e1bb. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMatthewHuff IanMatthewHuff merged commit 56a3539 into microsoft:master Feb 10, 2020
@IanMatthewHuff IanMatthewHuff mentioned this pull request Feb 11, 2020
Merged
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/inputBoxTweaks branch July 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IanMatthewHuff @codecov-io @DonJayamanne @rchiodo @DavidKutu