Skip to content

New "check out PR by number" is confusing#8467

Merged
alexr00 merged 2 commits intomainfrom
alexr00/issue8455
Feb 3, 2026
Merged

New "check out PR by number" is confusing#8467
alexr00 merged 2 commits intomainfrom
alexr00/issue8455

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 3, 2026

Fixes #8455

Copilot AI review requested due to automatic review settings February 3, 2026 09:37
@alexr00 alexr00 enabled auto-merge (squash) February 3, 2026 09:37
@alexr00 alexr00 self-assigned this Feb 3, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #8455 where users could filter PRs by title in the "checkout PR by number" picker, but selecting a PR from the filtered list would show an "Invalid pull request number or URL" error. The fix allows users to successfully select PRs from the list even when they've filtered by title, making the feature more ergonomic than manually entering PR numbers.

Changes:

  • Modified validation logic to allow PR selection from the list even when the label text (which includes the title) doesn't parse as a valid PR number
  • Restructured promise handling to load PRs in the background while showing the picker immediately, improving UX
  • Adjusted the flow to handle both typed input and list selection

@alexr00 alexr00 marked this pull request as draft February 3, 2026 09:46
@alexr00 alexr00 marked this pull request as draft February 3, 2026 09:46
auto-merge was automatically disabled February 3, 2026 09:46

Pull request was converted to draft

auto-merge was automatically disabled February 3, 2026 09:46

Pull request was converted to draft

@alexr00 alexr00 marked this pull request as ready for review February 3, 2026 10:07
@alexr00 alexr00 enabled auto-merge (squash) February 3, 2026 10:08
@alexr00 alexr00 merged commit 96adb0b into main Feb 3, 2026
6 checks passed
@alexr00 alexr00 deleted the alexr00/issue8455 branch February 3, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New "check out PR by number" is confusing

3 participants