Skip to content

Fix share permalink as markdown to use filename when invoked from tab context menu#8431

Merged
alexr00 merged 5 commits intomainfrom
copilot/fix-permalink-markdown-link-text
Feb 6, 2026
Merged

Fix share permalink as markdown to use filename when invoked from tab context menu#8431
alexr00 merged 5 commits intomainfrom
copilot/fix-permalink-markdown-link-text

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026 •
edited
Loading

"Copy GitHub Permalink as Markdown" from file tab context menu incorrectly uses the text at cursor position instead of the filename for the link text.

Changes

  • Modified copyMarkdownPermalink in src/issues/issueFeatureRegistrar.ts to detect invocation source
  • When context is a vscode.Uri (tab context menu): use filename
  • When context is an EditorLineNumberContext (gutter click): preserve existing behavior using selection text
const firstContext = context.length > 0 ? context[0] : undefined;
const contextIsFromTab = firstContext instanceof vscode.Uri;

if (withPermalinks.length === 1 && !contextIsFromTab) {
    const selection = this.getMarkdownLinkText(withPermalinks[0].range);
    // ... use selection text
}
// Otherwise use filename
Original prompt

This section details on the original issue you should resolve

<issue_title>Share permalink as markdown on tab should use filename for link text</issue_title>
<issue_description>Testing microsoft/vscode#177486

open a file and place your cursor somewhere in that file
right click the file tab and 'share github permalink as markdown`
🐛 the generated link will use the text at the cursor location, but seems like it should just be the filename
if the cursor isn't in that file, then the text seems to be picked up from its last location, possibly from another window</issue_description>

<agent_instructions>Pay special attention to #4663 (comment)</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@amunger the command will use the line as text when the editor is focused, and the filename if the editor is not focused.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 26, 2026 15:38
@alexr00
Initial plan for fixing share permalink markdown link text
40691a5 
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
@alexr00
Fix share permalink markdown to use filename when triggered from tab …
2a4289c 
…context menu

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix permalink markdown link text to use filename Fix share permalink as markdown to use filename when invoked from tab context menu Jan 26, 2026
Copilot AI requested a review from alexr00 January 26, 2026 15:44
@alexr00 alexr00 closed this Jan 30, 2026
@alexr00 alexr00 reopened this Jan 30, 2026
@alexr00 alexr00 marked this pull request as ready for review February 6, 2026 11:01
Copilot AI review requested due to automatic review settings February 6, 2026 11:01
@alexr00 alexr00 enabled auto-merge (squash) February 6, 2026 11:01
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 6, 2026
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where "Copy GitHub Permalink as Markdown" from the file tab context menu incorrectly used the text at the cursor position instead of the filename for the link text.

Changes:

  • Modified copyMarkdownPermalink to detect the invocation source by checking if the first context is a plain vscode.Uri
  • When invoked from tab context menu (plain vscode.Uri): uses filename
  • When invoked from gutter click (EditorLineNumberContext): preserves existing behavior using selection text

@alexr00 alexr00 merged commit 8ff1803 into main Feb 6, 2026
12 checks passed
@alexr00 alexr00 deleted the copilot/fix-permalink-markdown-link-text branch February 6, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chrmarti chrmarti chrmarti approved these changes

+1 more reviewer

@alexr00 alexr00 alexr00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexr00 alexr00

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

February 2026

Development

Successfully merging this pull request may close these issues.

Share permalink as markdown on tab should use filename for link text

4 participants

@chrmarti @alexr00