Copy GitHub Permalink doesn't work for GitHub Managed User (ghe.com)#7478
Merged
Copy GitHub Permalink doesn't work for GitHub Managed User (ghe.com)#7478
Conversation
Tyriar
reviewed
Jul 31, 2025
Comment on lines
-375
to
-377
| if (fetchUrl.startsWith('ssh://')) { | ||
| fetchUrl = fetchUrl.substr('ssh://'.length); | ||
| } |
Member
There was a problem hiding this comment.
This seems to remove more than what the PR title implies, are we losing anything important here/is there unwanted risk after testing has happened?
Member
Author
There was a problem hiding this comment.
The reason that copy permaklink didn't work for ghe.com was because I was not properly handling parsing the git remote when it wasn't https. Protocol's logic for parsing git remotes is more complete, and I should hav used Protocol here from the start. The change replaces the poor git remote parsing, with the more thorough Protocol class's git remote parsine.
I tested this with a github.com remote, a GitHub Enterprise remote, and a ghe.com remote.
benibenj
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7389