Skip to content

Don't show "make suggestion" when there's already a suggestion in the editor#6202

Merged
alexr00 merged 1 commit intomainfrom
alexr00/spotty-reindeer
Sep 6, 2024
Merged

Don't show "make suggestion" when there's already a suggestion in the editor#6202
alexr00 merged 1 commit intomainfrom
alexr00/spotty-reindeer

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Aug 30, 2024

Fixes #6195

@alexr00 alexr00 self-assigned this Aug 30, 2024
@alexr00 alexr00 marked this pull request as ready for review September 6, 2024 19:34
@alexr00 alexr00 enabled auto-merge (squash) September 6, 2024 19:34
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 6, 2024
@alexr00 alexr00 merged commit f685eaf into main Sep 6, 2024
@alexr00 alexr00 deleted the alexr00/spotty-reindeer branch September 6, 2024 20:47
@mfulton26
Copy link

GitHub web UI allows making multiple suggestions in a single comment. With this change will that still be possible? Maybe "Make a Suggestion" should only be disabled when the cursor is inside the suggestion code block/fence.

@alexr00
Copy link
Member Author

alexr00 commented Oct 4, 2024

With this change, the button is disabled, so you can't easily add another suggestion. Do you find yourself often adding multiple suggestions to one comment? What's your use case for this?

@mfulton26
Copy link

I don't think it is often, maybe every 1 in 30 comments. The main use case is when something needs cleaning-up but there are multiple ways to do it, so I'll leave two (sometimes even three) different suggestions to choose from. I think not limiting functionality in VSCode compared to GitHub UI is important in and of itself but as it isn't a critical thing (plus I can write ```suggestion out myself manually if needed) then I don't think it is critical to fix but it would be nice IMO (to have parity with GitHub UI, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow Make a suggestion button press if already have a suggestion in the comment

3 participants