Iterate the diffs in each active PR in order#5437
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom Nov 6, 2023
ThomsonTan:FixDiffNavigation
Merged
Iterate the diffs in each active PR in order#5437alexr00 merged 2 commits intomicrosoft:mainfrom ThomsonTan:FixDiffNavigation
alexr00 merged 2 commits intomicrosoft:mainfrom
ThomsonTan:FixDiffNavigation
Conversation
alexr00
approved these changes
Nov 6, 2023
Member
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thanks for the change!
sandy081
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For both
pr.goToNextDiffInPrandpr.goToPreviousDiffInPr, it tries to scroll the next invisible diff section into the editor view, this makes it not iterating each diff one by one. For example, if there are 3 diff sections in the beginning and all visible, callpr.goToNextDiffInPrscroll the 4th diff into editor view, this makes it a little hard to traverse each diffs.This PR sets the cursor to each diff while traverses each diff section one by one, without skipping any diff. The new behavior is also consistent with behavior of commands
workbench.action.compareEditor.nextChangeandworkbench.action.compareEditor.previousChange.