add setting to never offer ignoring default branch pr#5435
Merged
alexr00 merged 1 commit intomicrosoft:mainfrom Nov 6, 2023
Merged
add setting to never offer ignoring default branch pr#5435alexr00 merged 1 commit intomicrosoft:mainfrom
alexr00 merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="University of California Education Abroad Program" |
Member
|
@kurowski is there a reason you can't use the existing setting |
Contributor
Author
|
@alexr00 I believe that would work if we always wanted to ignore the pull request on the default branch, but the problem is that we never want to ignore the pull request. I can't figure out a way to get that behavior from the available settings. |
Member
|
I misunderstood, thanks for clarifying! |
alexr00
approved these changes
Nov 6, 2023
Member
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thanks for the PR!
benibenj
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my organization's workflow, we always have a PR associated with the default branch. And because we're heavy users of Dev Containers and Codespaces, our vscode workspaces are fairly ephemeral so we're always creating new ones.
Which means that in new workspaces we always see "there's a pull request associated with the default branch, do you want to ignore" notification and have to click the "Don't show" button. And since we create new environments frequently we see this notification frequently.
This pull request adds a setting to disable the offer to ignore PRs on the default branch, which improves our team's developer experience.