Fix UI for PR draft status check entry#4370
Merged
alexr00 merged 8 commits intomicrosoft:mainfrom Jan 5, 2023
Merged
Conversation
Thomas1664
commented
Dec 27, 2022
| .ready-for-review-text-wrapper { | ||
| display: flex; | ||
| gap: 8px; | ||
| align-items: center; |
Contributor
Author
There was a problem hiding this comment.
Also fixes icon on first row of status checks (see 'before' screenshot) is misaligned.
alexr00
requested changes
Dec 27, 2022
Member
alexr00
left a comment
There was a problem hiding this comment.
The editor webview looks good, but this adversely affects the sidebar webview
mmlinhang
reviewed
Jan 3, 2023
mmlinhang
reviewed
Jan 3, 2023
alexr00
requested changes
Jan 3, 2023
Member
alexr00
left a comment
There was a problem hiding this comment.
The sidebar webview now has the "Ready for review" button before the "This pr is a draft" message. It should be after.
Otherwise it looks good.
mmlinhang
reviewed
Jan 4, 2023
sandy081
approved these changes
Jan 5, 2023
Tyriar
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Without icon:
This screenshot was taken before I figured out that the icon in the first row of status checks was misaligned.