Skip to content

Issue #3371 | Updated getAuthSessionOptions in case of GitHub Enterprise AuthProvider#3565

Merged
alexr00 merged 1 commit intomicrosoft:mainfrom
jpspringall:issue/3371
May 30, 2022
Merged

Issue #3371 | Updated getAuthSessionOptions in case of GitHub Enterprise AuthProvider#3565
alexr00 merged 1 commit intomicrosoft:mainfrom
jpspringall:issue/3371

Conversation

@jpspringall
Copy link
Contributor

Resolves Unable to Access Enterprise Git Pull Requests #3371

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@hediet
Copy link
Member

hediet commented May 30, 2022

What is the difference between

getAuthSessionOptions = { ...getAuthSessionOptions, ...{ createIfNone: true, silent: false } };

and

getAuthSessionOptions = { ...getAuthSessionOptions, createIfNone: true, silent: false };

?

@alexr00
Copy link
Member

alexr00 commented May 30, 2022

@hediet I would expect those to do the exact same thing.

@alexr00 alexr00 merged commit b1d8928 into microsoft:main May 30, 2022
@jpspringall
Copy link
Contributor Author

@hediet I would expect those to do the exact same thing.

That is correct both do the same thing, I just copied the style that was there before

@jpspringall jpspringall deleted the issue/3371 branch May 30, 2022 22:42
@alexr00 alexr00 added this to the May 2022 milestone Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants