Skip to content

Creating a pull request doesn't use commit message for PR description when the base branch has more commits#3523

Merged
alexr00 merged 1 commit intomainfrom
alexr00/issue3350
May 6, 2022
Merged

Creating a pull request doesn't use commit message for PR description when the base branch has more commits#3523
alexr00 merged 1 commit intomainfrom
alexr00/issue3350

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented May 6, 2022

This PR does 2 things:

  1. Get title and description in method so that we don't make the same github calls twice.
  2. Remove git fallback for determining the number of commits between two branches and just uses the tip commit without additional calculation.
    Fixes Creating a pull request doesn't use commit message for PR description when the base branch has more commits #3350

@alexr00 alexr00 added this to the May 2022 milestone May 6, 2022
@sandy081 sandy081 self-requested a review May 6, 2022 09:41
@alexr00 alexr00 merged commit a783bb8 into main May 6, 2022
@alexr00 alexr00 deleted the alexr00/issue3350 branch May 6, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a pull request doesn't use commit message for PR description when the base branch has more commits

2 participants