Fix more React warnings of incorrect props.key#3214
Merged
alexr00 merged 3 commits intomicrosoft:mainfrom Jan 21, 2022
Merged
Conversation
There are some warnings in `CommentThread` because of misuse of `props.key`: `CommentThread`/`Diff` had no `key` prop, and `CommentThread` incorrectly forwareded `key` prop to child component.
blindpirate
commented
Dec 30, 2021
| const [revealed, setRevealed] = useState(!comment.isResolved); | ||
| const { openDiff } = useContext(PullRequestContext); | ||
| return ( | ||
| <div key={key} className="diff-container"> |
Contributor
Author
There was a problem hiding this comment.
special props (ref and key) are used by React, and are thus not forwarded to the component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some warnings in
CommentThreadbecause of misuse ofprops.key:CommentThread/Diffhad nokeyprop, andCommentThreadincorrectly forwarededkeyprop to child component.Update: found another missing
key propinMergedEvent: