Improves perceived performance of PR loading #2522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
reviewed
Feb 23, 2021
package.json
Outdated
| { | ||
| "view": "pr:github", | ||
| "when": "!github:initialized", | ||
| "contents": "Loading pull requests..." |
Contributor
There was a problem hiding this comment.
Actually, there's a point later when we are actually loading pull requests where we display "Loading...", so I think this text might be better as "Initializing..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preload command which can be triggered by Codespaces to put the PR extension in a "pr" loading state (e.g. in the correct view with a loading welcome message).
Also defers a lot of activation code until post-activation to improve perceived performance, since views will be show much quicker in a loading state.