Show reviewers in activity bar webview, disable approve and request changes on own pr #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
requested changes
Oct 6, 2020
| isIssue: false | ||
| isIssue: false, | ||
| isAuthor: currentUser.login === pullRequest.author.login, | ||
| reviewers: this.parseReviewers(requestedReviewers || [], timelineEvents || [], pullRequest.author) |
Member
There was a problem hiding this comment.
Now that we have ?? should we be using that to set default values instead of or? I don't feel super strongly, just curious what you think.
Contributor
Author
There was a problem hiding this comment.
Ah, I realize I didn't actually respond to this! I don't have strong opinions about this syntax, but I like it and think it's worth adopting
| * @param timelineEvents All timeline events for the pull request | ||
| * @param author The author of the pull request | ||
| */ | ||
| private parseReviewers(requestedReviewers: IAccount[], timelineEvents: TimelineEvent[], author: IAccount): ReviewState[] { |
Member
There was a problem hiding this comment.
Duplicate method from pullRequestOverview.ts?
alexr00
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2136